Correct CAMARA_common.yaml Generic503 error code to UNAVAILABLE, to match API design guidelines #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-murray
requested review from
shilpa-padgaonkar,
rartych,
patrice-conil,
RubenBG7 and
PedroDiez
as code owners
PedroDiez
reviewed
Dec 17, 2024
There was a problem hiding this comment.
There is a misaligment. Good catch Eric!
Indeed, I have realised I made a mistake from my side in PR#316
code should be kept to "UNAVAILABLE" (set "UNAVAILABLE" in Line 765), and line 771 kept unchanged (so wrong value currently is in line 765)
`
503 | UNAVAILABLE | Service Unavailable. | Service is not available. Temporary situation usually related to maintenance process in the server side -- | -- | -- | -- `
eric-murray
changed the title
|
@PedroDiez |
This was referenced Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Generic503 definition in CAMARA_common.yaml uses code value
SERVICE_UNAVAILABLEwhen defined code in API design guidelines isUNAVAILABLEWhich issue(s) this PR fixes:
Fixes # N/A
Does this PR introduce a breaking change?
Only a typo fix
Special notes for reviewers:
None
Changelog input
Additional documentation
None