-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Age Verification proposal aligned with Spring25 #175
base: main
Are you sure you want to change the base?
Updated Age Verification proposal aligned with Spring25 #175
Conversation
@fernandopradocabrillo, thanks for this PR and the update of errors section schema (new Commonalities version). I've started the discussion internally at Orange for the new response attributes. Gilles |
Co-authored-by: Eric Murray <[email protected]>
Co-authored-by: Eric Murray <[email protected]>
Co-authored-by: Eric Murray <[email protected]>
I'm happy with this, so approving. A couple of comments for you to think on:
|
@fernandopradocabrillo Thanks for this consolidated PR The latest API Design guidelines add requirements for
|
@eric-murray Thank you for the review! I will pass the linter locally, and I'll raise a PR to include it in the repo later (after Holidays probably haha) Regarding the birthdate, from TEF we agree... It was in the original proposal and I just left it there, but you are right, it doesn't make much sense. wdyt about the birthdate @GillesInnov35 @ToshiWakayama-KDDI |
Thanks @rartych, I have applied the changes to align with commonalities guidelines |
@eric-murray Hi Eric, this birthdate information is what the use claims it to be. If it it does not match, you are sure the end user is not the contract owner, and you can not return a reasonable answer. We propose to reply with "not_available" and not provide an identityMatchScore. See also the proposal I made here: #81 (comment) |
OK. So the API also allows the API consumer to confirm whether the DoB they have been given by the customer is correct. |
@eric-murray Yes, the DoB is then used as a first tollgate check. If it matches, you continue to processing the other input parameters that have been provided with which you can calculate the aggregate identity match score. |
Thank you for intensive review of Age Verification API. But, from KDDI side, I cannot accept all of this kind of last minute fundamental changes. We have already started implementation work, as this API has been discussed since January and the discussion had become stable before. From KDDI side, I would like to ask to revert url and path to the previous ones, i.e.
I do not think the above is not against commonalities guidelines. Sorry for the late response due to the time difference, but your understanding would be appreciated. Best reagrds, |
Hi all, I am checking other changes e.g. error responses, made by European colleagues during my night. Please allow me to take some time and comments. Best regards, |
Sorry, I think you mentioned this before. For me there is no problem in reverting to the previous name and aligning the filename. I like this one better, but I can live with it 😄 |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
This PR include all the changes and suggestions that haven been made these past months regarding Age Verification in PR #50.
It is a clean version with errors and descriptions aligned with the latest version of Commonalities for Spring25 meta release.
Additionally, it contains a proposal to include two new fields in the response:
contentLock
andparentalControl
. Both fields come from the feedback of our partners in the UK.This PR is ment to replace PR #50 as it seems easier to work on a updated fresh copy.
Please leave any comments or changes you feel appropriate.
Thanks!