Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements and Alignments in Errors #329

Merged
merged 6 commits into from
Dec 3, 2024
Merged

Enhancements and Alignments in Errors #329

merged 6 commits into from
Dec 3, 2024

Conversation

PedroDiez
Copy link
Collaborator

@PedroDiez PedroDiez commented Oct 30, 2024 •
edited by rartych
Loading

What type of PR is this?

  • enhancement

What this PR does / why we need it:

This PR is to address agreements within #321

  1. Alignment in Mandatory Error status to be documented in API Spec YAML
  2. Alignment in Error codes regarding "API Subject" identifier (device or phoneNumber) in API Design Guidelines Section 6.2. Aligned with Update error codes and info.description template for device / phone number identifiers #324

Which issue(s) this PR fixes:

Fixes #321

Does this PR introduce a breaking change?

  • Yes
  • No

Changes in error codes to be used in API defintions

Special notes for reviewers:

Ready for review

Changelog input

Commonalities aligment regarding mandatory error `status` in API Spec YAML and common terminology for "API Subject" identifier codes.

Additional documentation

N/A

@PedroDiez PedroDiez added the enhancement New feature or request label Oct 30, 2024
@PedroDiez PedroDiez mentioned this pull request Nov 5, 2024
Merged
2 tasks
@PedroDiez PedroDiez changed the title [WIP] Enhancements and Alignments in Errors Enhancements and Alignments in Errors Nov 5, 2024
@rartych rartych mentioned this pull request Nov 6, 2024
Open
@PedroDiez PedroDiez mentioned this pull request Nov 14, 2024
Merged
2 tasks
@eric-murray eric-murray mentioned this pull request Nov 15, 2024
Merged
@rartych rartych mentioned this pull request Nov 19, 2024
Closed
patrice-conil
patrice-conil previously approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych rartych linked an issue Nov 25, 2024 that may be closed by this pull request
Support & Aligment of 504 Exception in CAMARA APIs #308
Closed
@fernandopradocabrillo fernandopradocabrillo mentioned this pull request Nov 26, 2024
Open
@PedroDiez
Copy link
Collaborator Author

Working on this, i will advise you @rartych, @patrice-conil

@PedroDiez
Copy link
Collaborator Author

Please, you can check: latest commit 9365440

Hope have considered suitably your comments Rafal:

@PedroDiez PedroDiez mentioned this pull request Nov 29, 2024
Closed
@PedroDiez
Copy link
Collaborator Author

NOTE: Pending to review and align section 6.1. Please do not review yet

@rartych rartych mentioned this pull request Nov 29, 2024
Merged
2 tasks
@PedroDiez
Copy link
Collaborator Author

02/DIC: Ready for Review

patrice-conil
patrice-conil approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rartych
rartych approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@rartych rartych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych rartych merged commit 51a07c8 into camaraproject:main Dec 3, 2024
1 check passed
@bigludo7 bigludo7 mentioned this pull request Dec 9, 2024
Open
@Kevsy Kevsy mentioned this pull request Dec 13, 2024
Closed
6 tasks
This was referenced Dec 16, 2024
Open
Open
@Kevsy Kevsy mentioned this pull request Dec 16, 2024
Open
1 task
@FabrizioMoggio FabrizioMoggio mentioned this pull request Dec 17, 2024
Open
@rartych rartych mentioned this pull request Dec 19, 2024
Open
@bigludo7 bigludo7 mentioned this pull request Dec 20, 2024
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rartych rartych rartych approved these changes

@patrice-conil patrice-conil patrice-conil approved these changes

@shilpa-padgaonkar shilpa-padgaonkar Awaiting requested review from shilpa-padgaonkar shilpa-padgaonkar is a code owner

@RubenBG7 RubenBG7 Awaiting requested review from RubenBG7 RubenBG7 is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request Spring25
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancements and Alignments in Errors Support & Aligment of 504 Exception in CAMARA APIs
3 participants
@PedroDiez @patrice-conil @rartych