Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.1 #342

Merged
merged 15 commits into from
Dec 6, 2024
Merged

Release 2.1 #342

merged 15 commits into from
Dec 6, 2024

Conversation

rartych
Copy link
Collaborator

@rartych rartych commented Nov 21, 2024

What type of PR is this?

  • subproject management

What this PR does / why we need it:

This is Release PR for release 2.1 containing version v0.5.0-alpha.1 of Commonalities

Which issue(s) this PR fixes:

Fixes #340

Does this PR introduce a breaking change?

  • Yes, some of the included PR in the release are having breaking changes
  • No

Special notes for reviewers:

Changelog input

r2.1 containing version v0.5.0-alpha.1 of Commonalities

Additional documentation

@rartych rartych marked this pull request as ready for review November 29, 2024 19:30
@rartych
Copy link
Collaborator Author

rartych commented Nov 29, 2024

The description of PR# #329 will be added before final review

@rartych
Copy link
Collaborator Author

rartych commented Dec 3, 2024

Ready for final review

@rartych rartych requested a review from a team December 3, 2024 15:42
CHANGELOG.md Outdated Show resolved Hide resolved
Fixed typos and suggestions
Added camaraproject#351
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor points

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Pedro Díez García <[email protected]>
@rartych rartych requested a review from PedroDiez December 5, 2024 19:23
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for all the work.

For some of the listed PRs I'm not sure if the statement "no breaking change" is correct (from perspective of impacted API specifications). Have added comments there.

Copy link
Collaborator

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych rartych merged commit e13e6c4 into camaraproject:main Dec 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commonalities r2.1
4 participants