Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic test cases carrier billing payment #174

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

PedroDiez
Copy link
Collaborator

@PedroDiez PedroDiez commented Aug 20, 2024

What type of PR is this?

  • tests

What this PR does / why we need it:

Basic Tests for Carrier Billing API

Which issue(s) this PR fixes:

Partially Fixes #159

Special notes for reviewers:

Tests for Carrier Billing Refund will be uploaded in a separate PR

Changelog input

 Basic tests for Carrier Billing API

Additional documentation

N/A

@PedroDiez PedroDiez added the enhancement New feature or request label Aug 20, 2024
@PedroDiez PedroDiez self-assigned this Aug 20, 2024
@PedroDiez PedroDiez requested a review from rartych August 20, 2024 08:15
Copy link

github-actions bot commented Aug 20, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ OPENAPI spectral 2 0 3.94s
✅ REPOSITORY git_diff yes no 0.05s
✅ REPOSITORY secretlint yes no 1.04s
✅ YAML yamllint 2 0 0.83s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pedro for the effort.
No major issue from my perspective but some small things that I have caught.

@PedroDiez PedroDiez requested a review from bigludo7 August 27, 2024 08:58
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pedro for the corrections.
I went thru and this is OK for me.

@PedroDiez
Copy link
Collaborator Author

Thanks for the review Ludovic!

@PedroDiez PedroDiez merged commit 848a874 into main Aug 28, 2024
1 check passed
@PedroDiez PedroDiez deleted the basic_test_cases_carrier_billing_payment branch October 10, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing - Generate Gherkin Testing feature(s) for Carrier Billing for Meta-Release Fall24
2 participants