Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public Release for Fall24 meta-release #178

Merged
merged 10 commits into from
Sep 5, 2024
Merged

Conversation

PedroDiez
Copy link
Collaborator

@PedroDiez PedroDiez commented Aug 26, 2024

What type of PR is this?

Add one of the following kinds:

  • bug
  • correction
  • documentation
  • subproject management

What this PR does / why we need it:

PR to generate Public Release of Carrier Billing Checkout Family APIs

Which issue(s) this PR fixes:

Fixex #155
Fixes #168
Fixes #173
Fixes #175

Special notes for reviewers:

PRs #174 and #176 to be merged first than this one

Changes driven in API Spec YAMLs:

  • Apply File Name conventions (kebab-case)
  • Adjustment of version and servers values
  • Adjustment externalDocs link
  • Adjustment sink Description
  • Fix missing required request Body in confirmPayment operation
  • Fix 401 Error with Commonalities and also align the model of Errors with Commonalities "CAMARA_common.yaml" naming. - - Remove 400 PhoneNumber Required as Covered by 422 Exception

Changelog input

Public Release of Carrier Billing Family APIs for MetaRelease Fall24

Additional documentation

N/A

@PedroDiez PedroDiez self-assigned this Aug 26, 2024
@PedroDiez PedroDiez added documentation Improvements or additions to documentation enhancement New feature or request correction API specification needs correction subproject management Actions related to repository/releases labels Aug 26, 2024
@PedroDiez PedroDiez requested a review from rartych August 26, 2024 15:58
bigludo7
bigludo7 previously approved these changes Aug 26, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @PedroDiez
Up to @hdamker and the release Management team ;)

@PedroDiez PedroDiez changed the title [DRAFT] Public Release for Fall24 meta-release Public Release for Fall24 meta-release Aug 26, 2024
@PedroDiez PedroDiez requested review from bigludo7 and a team August 26, 2024 17:22
@hdamker
Copy link
Contributor

hdamker commented Aug 28, 2024

@PedroDiez If you want to have the meeting soon within main, you may want to do it in an own PR. Could take some days before the release PR gets approved by the RM team.

Copy link
Contributor

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • API Readiness checklists should be updated to r1.2 versions (without -rc suffixes), and resolve any pending tbd

@PedroDiez
Copy link
Collaborator Author

@PedroDiez If you want to have the meeting soon within main, you may want to do it in an own PR. Could take some days before the release PR gets approved by the RM team.

Thanks Herbert, I will comment tomorrow in the WG meeting. I think we can wait because relevant people is already aware of new schedule

Copy link
Contributor

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some projects are naming User stories with the same format than API-Readiness-Checklist, that is api-name-User-Story.md, but it is not made a requirement

@PedroDiez
Copy link
Collaborator Author

Some projects are naming User stories with the same format than API-Readiness-Checklist, that is api-name-User-Story.md, but it is not made a requirement

Thanks @jlurien I am applying it, It is fine to align

@PedroDiez PedroDiez requested a review from jlurien September 4, 2024 09:59
Copy link
Contributor

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of Release Management

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PedroDiez
Copy link
Collaborator Author

After TSC meeting, it can be merged:

SC Approval of M4 (all release PRs of Sub Project reviewed by Release Management)

  • We can merge PR when review completed
  • M4 Release tracker date: date when the merged is done by the project

@PedroDiez PedroDiez merged commit 0b804f9 into camaraproject:main Sep 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction API specification needs correction documentation Improvements or additions to documentation enhancement New feature or request subproject management Actions related to repository/releases
Projects
None yet
4 participants