Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproduce Node16 import issue #585

Closed
wants to merge 7 commits into from
Closed

Conversation

paul-sachs
Copy link
Member

@paul-sachs paul-sachs commented Oct 11, 2023

Run npm -w @bufbuild/protoplugin-example run build outputs errors:

../protoplugin/dist/cjs/ecmascript/index.d.ts:6:47 - error TS2307: Cannot find module '@bufbuild/protobuf/dist/cjs/private/names.js' or its corresponding type declarations.

6 export declare const localName: typeof import("@bufbuild/protobuf/dist/cjs/private/names.js").localName, reifyWkt: typeof import("@bufbuild/protobuf/dist/cjs/private/reify-wkt.js").reifyWkt;

../protoplugin/dist/cjs/ecmascript/index.d.ts:6:130 - error TS2307: Cannot find module '@bufbuild/protobuf/dist/cjs/private/reify-wkt.js' or its corresponding type declarations.

6 export declare const localName: typeof import("@bufbuild/protobuf/dist/cjs/private/names.js").localName, reifyWkt: typeof import("@bufbuild/protobuf/dist/cjs/private/reify-wkt.js").reifyWkt;
             

@timostamm
Copy link
Member

This has been fixed in #598. Closing. Thanks for the repro!

@timostamm timostamm closed this Oct 27, 2023
@timostamm timostamm deleted the psachs/node16-import-problem branch November 16, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants