Reproduce Node16 import issue

packages/protobuf/src/codegen-info.ts

@@ -20,17 +20,42 @@ import {
 import { getUnwrappedFieldType } from "./private/field-wrapper.js";
 import { scalarDefaultValue } from "./private/scalars.js";
 import { reifyWkt } from "./private/reify-wkt.js";
+import type {
+  DescEnum,
+  DescEnumValue,
+  DescField,
+  DescMessage,
+  DescMethod,
+  DescOneof,
+  DescService,
+} from "./descriptor-set";
+import { LongType, ScalarType } from "./field.js";
 
 interface CodegenInfo {
+  /**
+   * Name of the runtime library NPM package.
+   */
   readonly packageName: string;
-  readonly localName: typeof localName;
+  readonly localName: (
+    desc:
+      | DescEnum
+      | DescEnumValue
+      | DescMessage
+      | DescOneof
+      | DescField
+      | DescService
+      | DescMethod,
+  ) => string;
   readonly symbols: Record<RuntimeSymbolName, RuntimeSymbolInfo>;
-  readonly getUnwrappedFieldType: typeof getUnwrappedFieldType;
+  readonly getUnwrappedFieldType: (field: DescField) => ScalarType | undefined;
   readonly wktSourceFiles: readonly string[];
-  readonly scalarDefaultValue: typeof scalarDefaultValue;
+  readonly scalarDefaultValue: (type: ScalarType, longType: LongType) => any; // eslint-disable-line @typescript-eslint/no-explicit-any
+  /**
+   * @deprecated please use reifyWkt from @bufbuild/protoplugin/ecmascript instead
+   */
   readonly reifyWkt: typeof reifyWkt;
-  readonly safeIdentifier: typeof safeIdentifier;
-  readonly safeObjectProperty: typeof safeObjectProperty;
+  readonly safeIdentifier: (name: string) => string;
+  readonly safeObjectProperty: (name: string) => string;
 }
 
 type RuntimeSymbolName =
@@ -64,7 +89,7 @@ type RuntimeSymbolInfo = {
 const packageName = "@bufbuild/protobuf";
 
 export const codegenInfo: CodegenInfo = {
-  packageName,
+  packageName: "@bufbuild/protobuf",
   localName,
   reifyWkt,
   getUnwrappedFieldType,
@@ -108,4 +133,4 @@ export const codegenInfo: CodegenInfo = {
     "google/protobuf/type.proto",
     "google/protobuf/wrappers.proto",
   ],
-} as const;
+};

packages/protobuf/src/private/options-map.ts

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-import type { JsonValue } from "../json-format";
+import type { JsonValue } from "../json-format.js";
 
 /**
  *

packages/protobuf/src/private/reify-wkt.ts

@@ -91,6 +91,8 @@ type DescWkt =
     };
 
 /**
+ * @deprecated please use reifyWkt from @bufbuild/protoplugin/ecmascript instead
+ *
  * Reifies a given DescMessage into a more concrete object representing its
  * respective well-known type.  The returned object will contain properties
  * representing the WKT's defined fields.

packages/protoplugin-example/package.json

@@ -2,6 +2,7 @@
   "name": "@bufbuild/protoplugin-example",
   "version": "1.4.0",
   "private": true,
+  "type": "module",
   "scripts": {
     "build": "../../node_modules/typescript/bin/tsc --noEmit",
     "start": "npx esbuild src/index.ts --serve=localhost:3000 --servedir=www --outdir=www --bundle --global-name=eliza",

packages/protoplugin-example/test/generated.ts

@@ -14,8 +14,8 @@
 
 import * as assert from "node:assert/strict";
 import { describe, it, mock } from "node:test";
-import { ElizaServiceClient } from "../src/gen/connectrpc/eliza/v1/eliza_twirp";
-import { SayRequest } from "../src/gen/connectrpc/eliza/v1/eliza_pb";
+import { ElizaServiceClient } from "../src/gen/connectrpc/eliza/v1/eliza_twirp.js";
+import { SayRequest } from "../src/gen/connectrpc/eliza/v1/eliza_pb.js";
 
 describe("custom plugin", async () => {
   it("should generate client class", () => {

packages/protoplugin-example/tsconfig.json

@@ -2,7 +2,8 @@
   "include": ["src/**/*.ts", "test/*.ts"],
   "compilerOptions": {
     "target": "es2017",
-    "moduleResolution": "Node",
+    "moduleResolution": "Node16",
+    "module": "Node16",
     "esModuleInterop": false,
     "resolveJsonModule": true,
     "strict": true,

packages/protoplugin/src/ecmascript/index.ts

@@ -13,14 +13,14 @@
 // limitations under the License.
 
 import { codegenInfo } from "@bufbuild/protobuf";
-
+export { reifyWkt } from "./reify-wkt.js";
 export { Target } from "./target.js";
 export { Schema } from "./schema.js";
 export { RuntimeImports } from "./runtime-imports.js";
 export { GeneratedFile, FileInfo, Printable } from "./generated-file.js";
 export { ImportSymbol } from "./import-symbol.js";
 
-export const { localName, reifyWkt } = codegenInfo;
+export const { localName } = codegenInfo;
 
 export {
   createJsDocBlock,