Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an issue where feature states are being created without their initial states #155

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes an issue where feature states are being created without their initial states #155

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30fcc03
(fix): invokes reducer initially when ngrx is adding a feature state
congwenma May 9, 2020
d5091d0
Update src/index.ts
congwenma May 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import * as deepmerge from 'deepmerge';

const INIT_ACTION = '@ngrx/store/init';
const UPDATE_ACTION = '@ngrx/store/update-reducers';

congwenma marked this conversation as resolved.
Show resolved Hide resolved
const detectDate = /(\d{4})-(\d{2})-(\d{2})T(\d{2}):(\d{2}):(\d{2})/;

// correctly parse dates from local storage
Expand Down Expand Up @@ -273,7 +274,7 @@ export const localStorageSync = (config: LocalStorageConfig) => (

// If state arrives undefined, we need to let it through the supplied reducer
// in order to get a complete state as defined by user
if ((action.type === INIT_ACTION) && !state) {
if ((action.type === INIT_ACTION || action.type === UPDATE_ACTION) && !state) {
nextState = reducer(state, action);
} else {
nextState = { ...state };
Expand Down