Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes an issue where feature states are being created without their initial states #155

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes an issue where feature states are being created without their initial states #155

wants to merge 2 commits into from

Conversation

congwenma
Copy link

@congwenma congwenma commented May 9, 2020 •
edited
Loading

This addresses the problem that whenever you use forFeature you must explicitly add an initialState

StoreModule.forFeature('cars', carReducer, {
  metaReducers,
  // This was implicitly required
  initialState: carInitialState 
})

Should fix:

#96
#82

@ernestomancebo @btroncone @bufke Thoughts?

congwenma
congwenma commented May 13, 2020
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@BBlackwo BBlackwo added feature stores Functionality related to feature stores / modules known workaround There is a known workaround for this issue labels Aug 31, 2021
@BBlackwo BBlackwo mentioned this pull request Aug 31, 2021
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature stores Functionality related to feature stores / modules known workaround There is a known workaround for this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@congwenma @BBlackwo