chore: refactor B02_make_spectra_gFT.py #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpaniaguam
changed the title
Merged
|
@cpaniaguam I wonder if this PR conflicts with #90 . Does the latter already have the changes for B02_make_spectra_gFT.py ? |
@kmilo9999 Yes, it might be conflicting now as this is an older PR and too many changes have been added to the core code base. I will convert it to a draft and revisit whether some work could be salvaged later. |
|
Old PR. The code in make_spectra has changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple refactorings for improved readability