-
Notifications
You must be signed in to change notification settings - Fork 2
Issues: brown-ccv/icesat2waves
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Author
Label
Projects
Milestones
Assignee
Sort
Issues list
The elif branch does the same work as the else branch but this is for a different PR.
#197
opened Mar 13, 2024 by
hollandjg
I didn't notice this before either, but these functions (
get_var, get_N, get_lat) are used in a map call and need updated data in each iteration. I am curious about what might be a faster approach. One could define more general functions outside of the loop and then pass the data that is needed using a [lambda expression](https://docs.python.org/3/reference/expressions.html#lambda:~:text=about%20conditional%20expressions.-,6.14.%20Lambdas%C2%B6,-lambda_expr%20%3A%3A%3D%20%20%22lambda%22%20%5B) or a [partial function](https://docs.python.org/3/library/functools.html#functools.partial). In all three approaches 3 functions are created in each iteration. Hard to say which is the fastest without profiling.
#185
opened Mar 5, 2024 by
kmilo9999
This line adds more characters than using the original names below. I say delete them?
#169
opened Mar 4, 2024 by
kmilo9999
I didn't notice this before either, but these functions (
get_var, get_N, get_lat) are used in a map call and need updated data in each iteration. I am curious about what might be a faster approach. One could define more general functions outside of the loop and then pass the data that is needed using a [lambda expression](https://docs.python.org/3/reference/expressions.html#lambda:~:text=about%20conditional%20expressions.-,6.14.%20Lambdas%C2%B6,-lambda_expr%20%3A%3A%3D%20%20%22lambda%22%20%5B) or a [partial function](https://docs.python.org/3/library/functools.html#functools.partial). In all three approaches 3 functions are created in each iteration. Hard to say which is the fastest without profiling.
#157
opened Mar 4, 2024 by
kmilo9999
Refactor sample_with_mcmc class
🧹 Code cleanup
nice to have
#141
opened Mar 1, 2024 by
cpaniaguam
7 tasks
This block seems to be for computing
Gk_v2; I would put it in a function.
nice to have
#122
opened Feb 16, 2024 by
kmilo9999
This block seems like a good candidate to move to a function. What do you think?
nice to have
#120
opened Feb 16, 2024 by
kmilo9999
This block seems to be for computing
Gk_v2; I would put it in a function.
#117
opened Feb 16, 2024 by
kmilo9999
format all py files in project
🧹 Code cleanup
enhancement
New feature or request
#108
opened Feb 6, 2024 by
cpaniaguam
Previous Next
ProTip!
Follow long discussions with comments:>50.