Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature step3 integration #45

Merged
merged 16 commits into from
Jan 16, 2024
Merged

Feature step3 integration #45

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b57b886
adding B03_plot_spectra_ov.py to the new packagin structure
kmilo9999 Dec 11, 2023
57d9a22
cleaning and formatting files
kmilo9999 Dec 27, 2023
6b34132
remove analysis_db/B03_plot_spectra_ov.py
kmilo9999 Jan 11, 2024
0270181
added files and remove original file
kmilo9999 Jan 11, 2024
f34215d
added ci on step3
kmilo9999 Jan 11, 2024
ed627ed
chore: clean up startup.py
cpaniaguam Jan 11, 2024
dbc4c48
Merge branch 'main' into feat-step3-intg
kmilo9999 Jan 11, 2024
0e832fc
Merge pull request #55 from brown-ccv/feat-step3-intg-cleanup-startup.py
cpaniaguam Jan 12, 2024
2066f65
cleaning and formating ICEsat2_SI_tools/generalized_FT.py
kmilo9999 Jan 12, 2024
51cd07f
cleaning code, checking nan arrays to remove warnings, formatting file
kmilo9999 Jan 12, 2024
ee8f233
removing code and formating file
kmilo9999 Jan 12, 2024
afe459e
chore: update class definitions
cpaniaguam Jan 15, 2024
417d0ac
remving old class defition
kmilo9999 Jan 15, 2024
06d2e26
refactoring rebin funciton
kmilo9999 Jan 15, 2024
a8ea193
Merge pull request #66 from brown-ccv/update-legacy-class-definitions
cpaniaguam Jan 16, 2024
7895aaa
Merge branch 'feat-step3-intg' of https://github.com/brown-ccv/icesat…
kmilo9999 Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/test-B01_SL_load_single_file.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,6 @@ jobs:
- name: first step B01_SL_load_single_file
run: python src/icesat2_tracks/analysis_db/B01_SL_load_single_file.py 20190502052058_05180312_005_01 SH_testSLsinglefile2 True
- name: second step make_spectra
run: python src/icesat2_tracks/analysis_db/B02_make_spectra_gFT.py SH_20190502_05180312 SH_testSLsinglefile2 True
run: python src/icesat2_tracks/analysis_db/B02_make_spectra_gFT.py SH_20190502_05180312 SH_testSLsinglefile2 True
- name: third step make_spectra
kmilo9999 marked this conversation as resolved.
Show resolved Hide resolved
run: python src/icesat2_tracks/analysis_db/B03_plot_spectra_ov.py SH_20190502_05180312 SH_testSLsinglefile2 True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: python src/icesat2_tracks/analysis_db/B03_plot_spectra_ov.py SH_20190502_05180312 SH_testSLsinglefile2 True
run: python src/icesat2_tracks/analysis_db/B03_plot_spectra_ov.py SH_20190502_05180312 SH_testSLsinglefile2 True

Maybe formatters/pre-commit can be configured to add a new line at the end of files?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me add the formatter in another PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a local setting, though.

Loading