chore: logging 1 - remove stdout suppression in the rest of the app scripts #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hollandjg
changed the title
This was referenced Mar 4, 2024
|
@hollandjg Does this one need reviewing? On the surface looks the same as #176. |
This PR replaces the stdout-suppression in the analysis_db files, but doesn't make any changes to the logging. When reviewing this one, I recommend hiding whitespace changes: |
…ession # Conflicts: # src/icesat2waves/analysis_db/B02_make_spectra_gFT.py # src/icesat2waves/analysis_db/B04_angle.py
…ession # Conflicts: # src/icesat2waves/analysis_db/A02c_IOWAGA_thredds_prior.py # src/icesat2waves/analysis_db/B02_make_spectra_gFT.py # src/icesat2waves/analysis_db/B03_plot_spectra_ov.py # src/icesat2waves/analysis_db/B04_angle.py # src/icesat2waves/analysis_db/B05_define_angle.py # src/icesat2waves/analysis_db/B06_correct_separate_var.py
cpaniaguam
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the stdout-suppression in the
analysis_dbfiles, but doesn't make any changes to the logging.(These two changes are separated into separate PRs because the change in this PR is so noisy – it changes almost every line, but only really removes one statement – the context manager.)
builds on