DDO-3269: Environment V3 SQL Migrations #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No API changes detected |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
==========================================
+ Coverage 68.50% 68.52% +0.02%
==========================================
Files 157 157
Lines 10253 10250 -3
==========================================
Hits 7024 7024
+ Misses 2742 2740 -2
+ Partials 487 486 -1
|
…-enviornment-sql-migration
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to add the environment type to sherlock v3. This PR is doing the database migrations for that table based off of this function from the deprecated model.
Testing
I tested this locally by
starting up my local Sherlock. Doing this will run all the migrations and fail if there are any errors.
using the golang-migrate/migrate tool to test run my up and down migrations. I used
migrate -path sherlock/db/migrations -database 'postgres://sherlock:password@localhost:5432/sherlock?sslmode=disable' goto 61and
migrate -path sherlock/db/migrations -database 'postgres://sherlock:password@localhost:5432/sherlock?sslmode=disable' goto 62to test down and up, respectively.