Handle exceptions in client._task_network_consumer #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willholley
force-pushed
the
273-timeouts-2
branch
2 times, most recently
from
f19b817 to
9a59b6a
Compare
When exceptions bubble up to _task_network_consumer, log them and close the connection. This prevents the network consumer becoming unresponsive in the face of unhandled exceptions, which then surface as TimeoutErrors to GivTCP processes which are waiting on responses from the inverter.
willholley
force-pushed
the
273-timeouts-2
branch
from
9a59b6a to
352fe9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exceptions bubble up to _task_network_consumer, log them and close the connection.
This prevents the network consumer becoming unresponsive in the face of unhandled exceptions, which then surface as TimeoutErrors to GivTCP processes which are waiting on responses from the inverter.
This is complementary to #280 - this PR on its own addresses the generic problem of unhandled exceptions killing the network consumer, if it's undesirable to merge #280.