Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly yield Exception for invalid frame #280

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

willholley
Copy link

Issue: #273

Re-add the wrapping of exceptions raised during frame decoding to InvalidFrame. This ensures that the async framer.decode correctly yields the exception instead of raising it directly, which causes client._task_network_consumer to terminate silently.

Issue: britkat1980#273

Re-add the conversion of frame decoding exceptions to
InvalidFrame. This ensures that the async `framer.decode`
correctly yields any exception instead of raising it
directly and terminating `client._task_network_consumer`.
@willholley
Copy link
Author

#281 also addresses this problem at a higher level, though I think both changes are valid protections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant