Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced tab group icon in bookmarks bar #26925

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Dec 7, 2024

fix brave/brave-browser#42535

Screenshot 2024-12-14 at 9 44 24 AM

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See the linked issue

@simonhong simonhong added the CI/skip Do not run CI builds (except noplatform) label Dec 7, 2024
@simonhong simonhong self-assigned this Dec 7, 2024
@simonhong simonhong requested a review from aguscruiz December 14, 2024 00:45
@simonhong simonhong removed the CI/skip Do not run CI builds (except noplatform) label Dec 14, 2024
@simonhong simonhong force-pushed the replace_tab_group_icon branch from 83b1f91 to e660af0 Compare December 14, 2024 00:45
@simonhong simonhong marked this pull request as ready for review December 14, 2024 00:45
Copy link
Collaborator

@aguscruiz aguscruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@simonhong simonhong merged commit 4dae430 into master Dec 15, 2024
18 checks passed
@simonhong simonhong deleted the replace_tab_group_icon branch December 15, 2024 01:08
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 15, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.101

boocmp pushed a commit that referenced this pull request Dec 16, 2024
Replaced tab group icon in bookmarks bar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CR132] Update the Tab groups icon (looks like four squares) in the bookmarks bar
3 participants