-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CR132] Update the Tab groups icon (looks like four squares) in the bookmarks bar #42535
Comments
Pushed brave/brave-core#26925 but it seems current master doesn't have |
Yeah, we need a bump, I just created that icon today 😬 |
It seems latest nala bump doesn't include this - brave/brave-core#26995 |
@simonhong we'll probably want this one uplifted into |
@kjozwiak This change depends on latest |
Gotcha, thanks @simonhong 👍 In that case, we can let this ride the trains. It's a really minor issue and uplifting |
Verification
Verified using STR from the description Tab groups icon on the bookmarks bar seem clipped. Visually the icon doesn't seem to match to Figma design as it has more rounded corners than the icon shown - Failed Filed a follow up - #43236 |
Description
Found while testing #42521.
Steps to reproduce
Actual result
Tab groups icon (looks like four squares) and is inherited from Chromium.
Expected result
No tab groups icon similar to 1.73.x?
Reproduces how often
Easily reproduced
Brave version (brave://version info)
Channel information
Reproducibility
Miscellaneous information
@rebron @emerick
cc: @brave/qa-team
The text was updated successfully, but these errors were encountered: