Added the Romanian language and an experimental Romanian translation #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks a lot for the contribution! This looks good to me.
The about page and its translations comes from libadwaita, which can be translated on GNOME's centralized translation system. The text on the "What's New" page will always be in English since changelogs usually don't get translated. |
|
I am glad I could help! I will be closing the issue I have created as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the examples of the previous entries, I added the option to use Romanian words for typing. For now, I used the recommended list of words from Monkeytype's language directory, but it would be a good idea to use a different list in the future. The Romanian language has 5 special characters (ă, â, î, ș, ț) which are often replaced by their standard Latin counterparts (a, i, s, t) in casually written text. As such, it would be nice to have a simple list without special characters, and an advanced list for the full range of characters. Apart from that, I have changed the quotation marks for Romanian, as it uses an identical rule to Bulgarian.
I also translated the app in Romanian, but since I never use the Romanian interface I am not sure if the phrasing used is in line with Gnome conventions. I tested it and it looks fine, so albeit not perfect, I think it is a good start. I have noticed that the About page is not translated, but I am not sure if that is intended or not.