fix: script task result variable scope redefines if output mapping exists #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
nikku
force-pushed
the
script-variable-scope
branch
from
67cdf23 to
3322ea3
Compare
barmac
reviewed
Dec 17, 2024
Comment on lines
39
to
51
| // Checks if output variable exists, the scope gets redefined | ||
| if (processVariables.some(x => x.origin[0] === element && x.scope === containerElement)) { | ||
|
|
||
| // result variable will have local scope | ||
| containerElement = element; | ||
| } | ||
|
|
There was a problem hiding this comment.
[suggestion] Let's add an example to the functions JSDoc
|
Since this pull request applies to Business Rule Task implemented as a DMN decision, I'd suggest to add a respective test case, and document it in the pull request. When this is done, I think it's ready to merge. Great job :) |
barmac
approved these changes
Dec 17, 2024
abdul99ahad
force-pushed
the
script-variable-scope
branch
from
3322ea3 to
cbad563
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: camunda-modeler #4737
Proposed Changes
Script Task
If output mapping exists, result variable scope should be local.
If output mapping doesn't exist, result variable scope is global.
You can test the implementation by running this command:
npx @bpmn-io/sr bpmn-io/variable-resolver#variable-scoping -l bpmn-io/extract-process-variables#script-variable-scopeChecklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}