Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEEL variable scope resolution #43

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

FEEL variable scope resolution #43

wants to merge 3 commits into from

Conversation

abdul99ahad
Copy link
Contributor

@abdul99ahad abdul99ahad commented Dec 16, 2024

Related to: camunda-modeler #4737

Proposed Changes

When script result variable and input with same names coexist, result variable overwrites the input variable.
Dec-16-2024 23-19-02

When same name input/output mapping exists, the later one overwrites the previous one.
Dec-16-2024 23-19-50

You can test the implementation by running this command: npx @bpmn-io/sr bpmn-io/variable-resolver#variable-scoping -l bpmn-io/extract-process-variables#script-variable-scope

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Dec 16, 2024
@abdul99ahad
Copy link
Contributor Author

Requires fixed-upstream: bpmn-io/extract-process-variables#30

@abdul99ahad abdul99ahad requested review from nikku and barmac December 16, 2024 18:24
@abdul99ahad abdul99ahad marked this pull request as draft December 16, 2024 18:28
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress Currently worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant