Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview Append #1985

Merged
merged 5 commits into from
Oct 30, 2023
Merged

Preview Append #1985

merged 5 commits into from
Oct 30, 2023

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Oct 20, 2023 •
edited
Loading

brave_LhiZ5ATZjp

Changes

  • context pad
    • preview append on hover
  • renderer
    • fill, stroke, width and height can be overridden
    • no other attributes can be overridden
    • public API only exposes renderers for actual BPMN elements

Follow-Ups

Closes #1990

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Oct 20, 2023
@philippfromme philippfromme mentioned this pull request Oct 24, 2023
Open
@philippfromme philippfromme force-pushed the complex-preview branch 2 times, most recently from 3ce5c33 to c741f7b Compare October 25, 2023 11:35
@philippfromme philippfromme marked this pull request as ready for review October 25, 2023 11:54
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 25, 2023
@philippfromme philippfromme force-pushed the complex-preview branch 2 times, most recently from 820b626 to ff56183 Compare October 26, 2023 10:02
@philippfromme
Copy link
Contributor Author

@barmac @marstamm I've added back the opacity and updated the changelog.

barmac
barmac reviewed Oct 26, 2023
View reviewed changes
Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mark BpmnRenderer changes as breaking? We are removing parts of the public API.
Other than that it looks good to me. I love how it improves the UX of the editor.

@barmac
Copy link
Member

barmac commented Oct 26, 2023

There is one problem I found but it's not a regression. Namely, we are fixing here the participant multiplicity marker position, but it's still broken for subprocess:

image

It is this way in bpmn-js right now too, so it's possibly a follow-up issue.

marstamm
marstamm reviewed Oct 26, 2023
View reviewed changes
Copy link
Contributor

@marstamm marstamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So Subprocess and Call activity are rendered with the same border width. Is this an oversight or do we have the same issues with this approach like we had when I tried to rework the renderer?

image

@barmac
Copy link
Member

barmac commented Oct 26, 2023

Is this an oversight or do we have the same issues with this approach like we had when I tried to rework the renderer?

Looks like a bug to me! :(

marstamm
marstamm requested changes Oct 26, 2023
View reviewed changes
lib/draw/BpmnRenderer.js Outdated Show resolved Hide resolved
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Oct 26, 2023
@barmac
Copy link
Member

barmac commented Oct 26, 2023

Business Rule Task is broken too:

image

Current:

image

@philippfromme
feat(context-pad): preview append on hover
428fff0
@philippfromme
feat(bpmn-renderer): allow overriding colors, width, and height
cf44625 
* fill, stroke, width and height can be overridden
* no other attributes can be overridden
* public API only exposes renderers for actual BPMN elements

Closes #1990
@philippfromme
fix: fix tests failing due to lazy instantiation of eventDefinitions
aa0c81c 
* since the renderer now accesses `eventDefinitions` through the getter it's lazily instantiated and therefore not undefined; the tests should assume undefined in the first place
* remove unused `bpmnReplace` dependencies
@philippfromme
chore(CHANGELOG): update
636cc6d
@philippfromme
chore: move tests to main describe
6a903cd
@philippfromme
Copy link
Contributor Author

  • added breaking changes to changelog
  • fixed call activity stroke width
  • fixed sequential marker position
  • fixed business rule task icon

Ready for another review.

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Oct 27, 2023
@philippfromme philippfromme requested a review from barmac October 27, 2023 13:42
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Oct 27, 2023
@barmac barmac merged commit 6160183 into develop Oct 30, 2023
11 checks passed
@barmac barmac deleted the complex-preview branch October 30, 2023 13:52
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 30, 2023
@barmac
Copy link
Member

barmac commented Oct 30, 2023

Let's release it! 🚀

@barmac barmac mentioned this pull request Oct 30, 2023
Merged
@philippfromme philippfromme mentioned this pull request Oct 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac approved these changes

@marstamm marstamm marstamm approved these changes

Assignees

@philippfromme philippfromme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Participant Multiplicity Marker Not Centered
3 participants
@philippfromme @barmac @marstamm