Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview Support Should Use Renderer for Preview #816

Open
philippfromme opened this issue Oct 24, 2023 · 0 comments
Open

Preview Support Should Use Renderer for Preview #816

philippfromme opened this issue Oct 24, 2023 · 0 comments
Labels
backlog Queued in backlog enhancement New feature or request spring cleaning Could be cleaned up one day

Comments

@philippfromme
Copy link
Contributor

The PreviewSupport feature clones an SVG and then applies fill and stroke on all of its elements. This leads to rendering errors like:

image

A better way of rendering the preview would be to render the element using the renderer but with custom colors:

graphicsFactory.drawShape(getVisual(gfx), element, {
  fill: 'red',
  stroke: 'green'
});
@philippfromme philippfromme added enhancement New feature or request backlog Queued in backlog spring cleaning Could be cleaned up one day labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog enhancement New feature or request spring cleaning Could be cleaned up one day
Projects
None yet
Development

No branches or pull requests

1 participant