-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Output markdown as Step Summary and Text, and Optionally Output PR comment #35
base: main
Are you sure you want to change the base?
Conversation
952dc8f
to
f47b420
Compare
8dff9d6
to
26a87c6
Compare
26a87c6
to
3ae85d4
Compare
Only attempt commenting if in a pr context. Otherwise don't
@borchero have followed up on your feedback for your review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great already, thank you! I left a couple suggestions :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates, I think we're almost there! 🚀
One more request: could you introduce a parameter skip-comment
to the action (and document it in the README)? This would allow people to only use the summary if they want and would finally allow me to fix the CI for pull requests (as forks cannot create PR comments...).
a9f4dab
to
fe15cdf
Compare
@borchero resolved your previous comments for you to look at |
Motivation
Warning
This is a duplicate of #34 because I've never used github fork/sync before and wiped my changes, which closed the previous PR. This is a recovery, improvement, and refiling of that PR.
Supports non-pr use cases by outputting raw markdown as output. Make "commenting" optional as well.
Always output markdown into GITHUB_STEP_SUMMARY.
From my testing the standard PR commenting behaviour appears to be unchanged when the action is triggered by a pr.
Changes
Example Use Case
Here is an example of me using this adjusted action to output markdown into a GITHUB_STEP_SUMMARY (not a comment!) before a job that requires environment-specific approval.