Carbonapi/from until times verification #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bom-d-van
force-pushed
the
carbonapi/from-until-times-verification
branch
2 times, most recently
from
86d1b32 to
477853a
Compare
* Fix a date test case of unix timestamp * Fix some linter errors of fmt.Errorf * Make test output verbose
bom-d-van
force-pushed
the
carbonapi/from-until-times-verification
branch
from
477853a to
e634917
Compare
grzkv
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this change attempting to solve?
For issue #171
How does this change solve the problem? Why is this the best approach?
More strict validation checks.
How can we be sure this works as expected?
Unit and production test.
The core of the changes are from Vladimir Pestov's MR here: #200
With some rebase conflict resolution and minor updates on
writeErrorcall inApp.renderHandler.