Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict from and until times verification in api #171

Closed
grzkv opened this issue Jun 17, 2019 · 3 comments
Closed

Add strict from and until times verification in api #171

grzkv opened this issue Jun 17, 2019 · 3 comments
Assignees

Comments

@grzkv
Copy link
Member

grzkv commented Jun 17, 2019

Currently, api accepts some times that are either too liberal or just incorrect. In this case, the defaults are applied that either are not obvious or include timeframe that starts "at the beginning of time" (for Unix).

E.g.

http://localhost:8081/render?target=a.a.a&from=+5m (future)
http://localhost:8081/render?target=a.a.a&until=+5m (from implied to come since forever and into the future)

There are more similar cases.

This is closely related to #160

@grzkv
Copy link
Member Author

grzkv commented Jun 17, 2019

@KozzyKoder You may be interested in this one.

@azhiltsov
Copy link
Contributor

azhiltsov commented Jul 9, 2019

Also would be nice to prevent swap of from and until
from go-carbon logs:
Invalid time interval: from time '1562536741' is after until time '1561932061'

@bom-d-van
Copy link
Collaborator

the issue is resolved by #200 and #341 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants