-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: group BUSCO stats into collapsible sections for better display #148
Conversation
Introduce parallelization
…e sample MANIFEST should onyl contain samples from respective partition
…line Also output BUSCOResults artifact
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
==========================================
- Coverage 97.76% 97.72% -0.04%
==========================================
Files 53 64 +11
Lines 3126 3390 +264
==========================================
+ Hits 3056 3313 +257
- Misses 70 77 +7 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Santiago Castro Dau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Michal! Crazy amount of work that you put into this one 👨🏼💻! I really like how it looks now ✨ . Also I imagine the added information with in the index page (the histograms) can be very valuable to users 📈 .
Most of my review I did in single comments already. This is just the conclusion message.
- ✅ All test pass in my local machine.
- ✅ I tried the action on two different inputs and I could not find any issues with the visualizations.
This PR addresses the problem of displaying BUSCO results for hundreds and thousands of MAGs. The problem with the previous solution was its reliance on vegafusion transformer which caused some installation issues in our distro. This PR tries to approach the problem differently:
Closes #140.