Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add action to estimate MAG abundance #177

Merged
merged 13 commits into from
Aug 30, 2024

Conversation

misialq
Copy link
Contributor

@misialq misialq commented Jun 7, 2024

This PR adds an action to estimate abundances of dereplicated MAGs in the original samples. The estimation is done in the following way:

  1. Reads are mapped to the dereplicated MAGs (using the map-reads action from q2-assembly).
  2. Coverage of each MAG is calculated using the samtools coverage command.
  3. The metric of choice (RPKM or TPM) is calculated using the coverage report (from which the read counts per MAG are obtained) and reported in the final table.

Depends on bokulich-lab/q2-assembly#81.

@misialq
Copy link
Contributor Author

misialq commented Jun 7, 2024

/q2ci

Edit: Running QIIME 2 CI...

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.96%. Comparing base (e16ac9d) to head (bdeec3f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
- Coverage   98.47%   97.96%   -0.52%     
==========================================
  Files          82      155      +73     
  Lines        4600     9298    +4698     
  Branches        0      409     +409     
==========================================
+ Hits         4530     9109    +4579     
- Misses         70      140      +70     
- Partials        0       49      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This PR/issue depends on:

@misialq misialq marked this pull request as ready for review August 27, 2024 16:46
@misialq
Copy link
Contributor Author

misialq commented Aug 27, 2024

For reviewers: this action was already tested against some real data so (unless you want to try it out) feel free to focus mostly on the code review. Thanks! 🙏

@misialq misialq requested review from a team and ChristosMatzoros and removed request for a team August 27, 2024 16:47
Copy link
Contributor

@ChristosMatzoros ChristosMatzoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @misialq, the code looks good to me! You can merge! 🚀

@misialq misialq merged commit c58cd10 into bokulich-lab:main Aug 30, 2024
9 of 10 checks passed
@misialq misialq deleted the normalization branch August 30, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants