Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add action to extract a specific annotation into a feature table #178

Merged
merged 34 commits into from
Aug 30, 2024

Conversation

misialq
Copy link
Contributor

@misialq misialq commented Jun 18, 2024

This PR introduces two new actions:

  1. extract-annotations which can accept a GenomeData[NOG] artifact and extract the specified annotation (e.g. KEGG_pathways) into a new feature table
  2. multiply-tables which can take two feature tables (with matching dimensions) and return their dot product - here the use case is calculating per-sample counts of annotation features extracted with the action 1. by getting the dot product of that table and the MAG abundance feature table which can be obtained from an action in ENH: add action to estimate MAG abundance #177.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.56%. Comparing base (c58cd10) to head (db87340).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   98.50%   98.56%   +0.06%     
==========================================
  Files          85       85              
  Lines        4679     4882     +203     
==========================================
+ Hits         4609     4812     +203     
  Misses         70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@misialq misialq marked this pull request as ready for review August 29, 2024 12:55
@misialq misialq requested review from a team and ChristosMatzoros and removed request for a team August 29, 2024 12:55
Copy link
Contributor

@ChristosMatzoros ChristosMatzoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, see the comments below.

q2_moshpit/eggnog/annotation.py Show resolved Hide resolved
q2_moshpit/eggnog/annotation.py Outdated Show resolved Hide resolved
q2_moshpit/_utils.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ChristosMatzoros ChristosMatzoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @misialq, thanks for making the changes. It looks great! 🚀

@misialq misialq merged commit 1bb3e46 into bokulich-lab:main Aug 30, 2024
10 checks passed
@misialq misialq deleted the annot-improvements branch August 30, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants