-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: evaluate-busco brakes when input mags > ~1,300 #142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Sann5, thanks for fixing that! I changed the code slightly to remove the dependency on the vegatransformer
- with this present I would constantly get errors that some packages are missing in the environment. Besides, this was needed to display more than 5k rows, right? So I guess we don't need it anyway, unless you kept it there on purpose? In any case, I'm merging this one now and we can see later whether we should think about that transformer again.
I'm not super sure @michal but think the transformer might be needed. I can't remember if the visualization broke earlier (with a smaller dataset) or rather if it was needed for the search box function to work correctly. But if you tried this out with a large dataset and it worked then we are good to go :). |
What's new
vega
has a limit on the size of the plots that can be computed.evaluate-busco
action was erroring out.evaluate-busco
brakes when input mags > ~1,300 #140Run it locally
q2-moshpit
that is installed in your virtual environment.cd q2-moshpit gh pr checkout 142
Running the tests