Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Test failure for test_draw_busco_plots_for_render #146

Closed
ebolyen opened this issue Mar 11, 2024 · 3 comments
Closed

BUG: Test failure for test_draw_busco_plots_for_render #146

ebolyen opened this issue Mar 11, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@ebolyen
Copy link
Contributor

ebolyen commented Mar 11, 2024

Describe the bug

Trying to get the prepare set up so that we can have a dev environment for the shotgun distro. I'm seeing some issues with the Vega test for busco. It looks like the JSON has shifted a little bit and it's causing the tests to fail with altair=5.2.0.

FAILED test-env/lib/python3.8/site-packages/q2_moshpit/busco/tests/test_utils.py::TestBUSCO::test_draw_busco_plots_for_render - AssertionError: {'autosize': {'resize': True, 'type': 'pad'[19667 chars]0'}]} != {'config': {'autosize': {'resize': True}, '[11809 chars]': 3}

I suspect this PR is related: #142
Notably, we've got

+  'spacing': 3}

in the assertion failure (although I can't tell from which direction the spacing is added or missing), but that was changed in the above PR.

To Reproduce
See https://github.com/qiime2/distributions/actions/runs/8237435747/job/22532811036

@ebolyen ebolyen added the bug Something isn't working label Mar 11, 2024
@ebolyen
Copy link
Contributor Author

ebolyen commented Mar 11, 2024

For a limited window, we can download the built conda packages:
https://github.com/qiime2/distributions/actions/runs/8237435747/artifacts/1316571672
And environment file which is under test:
https://github.com/qiime2/distributions/actions/runs/8237435747/artifacts/1316571675
(you will need to rename the top channel to match your extracted conda package channel location)

@misialq
Copy link
Contributor

misialq commented Mar 14, 2024

Hey @ebolyen, I'm guessing this got "fixed" after the revert in #147? Should we keep this open or we close and re-open when it re-surfaces again in the next BUSCO PRs?

@ebolyen ebolyen closed this as completed Mar 14, 2024
@ebolyen
Copy link
Contributor Author

ebolyen commented Mar 14, 2024

CI should catch it this time around!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants