Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privatize JsValue's internals and expose it through a JsVariant (with immutable reference) #4080

Merged
merged 21 commits into from
Dec 19, 2024

Add more tests and fix them

1cd5732
Select commit
Loading
Failed to load commit list.
Merged

Privatize JsValue's internals and expose it through a JsVariant (with immutable reference) #4080

Add more tests and fix them
1cd5732
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 18, 2024 in 0s

53.74% (+6.50%) compared to 6ddc2b4

View this Pull Request on Codecov

53.74% (+6.50%) compared to 6ddc2b4

Details

Codecov Report

Attention: Patch coverage is 55.58511% with 334 lines in your changes missing coverage. Please review.

Project coverage is 53.74%. Comparing base (6ddc2b4) to head (1cd5732).
Report is 319 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/value/operations.rs 54.09% 56 Missing ⚠️
core/engine/src/value/mod.rs 77.86% 27 Missing ⚠️
core/engine/src/value/variant.rs 54.00% 23 Missing ⚠️
core/engine/src/value/conversions/try_from_js.rs 51.35% 18 Missing ⚠️
core/engine/src/object/builtins/jsdate.rs 0.00% 15 Missing ⚠️
core/engine/src/builtins/typed_array/builtin.rs 31.57% 13 Missing ⚠️
core/engine/src/object/builtins/jsset.rs 0.00% 10 Missing ⚠️
core/engine/src/builtins/temporal/duration/mod.rs 55.55% 8 Missing ⚠️
...ore/engine/src/builtins/temporal/plain_time/mod.rs 0.00% 8 Missing ⚠️
core/engine/src/object/builtins/jsfunction.rs 11.11% 8 Missing ⚠️
... and 45 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4080      +/-   ##
==========================================
+ Coverage   47.24%   53.74%   +6.50%     
==========================================
  Files         476      485       +9     
  Lines       46892    48139    +1247     
==========================================
+ Hits        22154    25874    +3720     
+ Misses      24738    22265    -2473

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov