Privatize JsValue's internals and expose it through a JsVariant (with immutable reference)
#4080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4080 +/- ##
==========================================
+ Coverage 47.24% 53.74% +6.50%
==========================================
Files 476 485 +9
Lines 46892 48139 +1247
==========================================
+ Hits 22154 25874 +3720
+ Misses 24738 22265 -2473 ☔ View full report in Codecov by Sentry. |
hansl
changed the title
JsValue's internals and expose it through a JsVariant (with immutable reference)
raskad
requested changes
Dec 15, 2024
|
Something is still bugged: |
|
Yes, I'll move some of these to unit tests to be easier to prevent regressions. |
|
@raskad I've had to put back converting float to i32 as a float, and better compare with negative zero, but now it passes all tests and all test262 locally. This should be ready. |
nekevss
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
JsValueto being a struct with an internal enumeration. This prevents people from deconstructing or constructing values directly, instead they should rely on helper methods (likeas_*()) or using theJsVariantwhich contains references to the internal value.The direction here is that we will change the interior representation of JsValue in the near future and this new representation will not be compatible with enum deconstruction / pattern matching.
There is no deprecation strategy here; every PR that add usage of
JsValueas an enum will have a merge conflict or a test error. Every dependents doing the same will break when they update.Fixes #3761.