Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal: Update Date builtin with boa_temporal and fixes #3614

Merged
merged 1 commit into from
Jan 27, 2024

New date methods and update builtin

ed32d15
Select commit
Loading
Failed to load commit list.
Merged

Temporal: Update Date builtin with boa_temporal and fixes #3614

New date methods and update builtin
ed32d15
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 25, 2024 in 0s

47.36% (-0.12%) compared to eba393f

View this Pull Request on Codecov

47.36% (-0.12%) compared to eba393f

Details

Codecov Report

Attention: 175 lines in your changes are missing coverage. Please review.

Comparison is base (eba393f) 47.47% compared to head (ed32d15) 47.36%.

Files Patch % Lines
...ore/engine/src/builtins/temporal/plain_date/mod.rs 0.00% 89 Missing ⚠️
core/temporal/src/components/date.rs 0.00% 82 Missing ⚠️
core/temporal/src/iso.rs 0.00% 2 Missing ⚠️
core/engine/src/builtins/temporal/now.rs 0.00% 1 Missing ⚠️
core/temporal/src/components/duration/date.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3614      +/-   ##
==========================================
- Coverage   47.47%   47.36%   -0.12%     
==========================================
  Files         475      475              
  Lines       46035    46142     +107     
==========================================
- Hits        21855    21853       -2     
- Misses      24180    24289     +109

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov