Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal: Update Date builtin with boa_temporal and fixes #3614

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Jan 25, 2024

This Pull Request is related to #1804. This begins to add functionality in boa_temporal to the Temporal builtins (with hopefully more to come).

It changes the following:

  • Adds some methods to Date in boa_temporal.
  • Implements some of the existing and pre-existing Date methods for the PlainDate builtin.
  • There are some bug fixes for some tests in test262 also that were panicking.

Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,960 95,960 0
Passed 76,594 76,594 0
Ignored 18,477 18,477 0
Failed 889 889 0
Panics 0 0 0
Conformance 79.82% 79.82% 0.00%

@nekevss nekevss added builtins PRs and Issues related to builtins/intrinsics waiting-on-review Waiting on reviews from the maintainers labels Jan 25, 2024
@nekevss nekevss added this to the v0.18.0 milestone Jan 25, 2024
@nekevss nekevss requested a review from a team January 25, 2024 21:48
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 175 lines in your changes are missing coverage. Please review.

Comparison is base (eba393f) 47.47% compared to head (ed32d15) 47.36%.

Files Patch % Lines
...ore/engine/src/builtins/temporal/plain_date/mod.rs 0.00% 89 Missing ⚠️
core/temporal/src/components/date.rs 0.00% 82 Missing ⚠️
core/temporal/src/iso.rs 0.00% 2 Missing ⚠️
core/engine/src/builtins/temporal/now.rs 0.00% 1 Missing ⚠️
core/temporal/src/components/duration/date.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3614      +/-   ##
==========================================
- Coverage   47.47%   47.36%   -0.12%     
==========================================
  Files         475      475              
  Lines       46035    46142     +107     
==========================================
- Hits        21855    21853       -2     
- Misses      24180    24289     +109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raskad raskad requested a review from a team January 27, 2024 19:52
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat added this pull request to the merge queue Jan 27, 2024
Merged via the queue into main with commit 806c3c9 Jan 27, 2024
14 checks passed
@HalidOdat HalidOdat deleted the temporal-date-builtin branch January 27, 2024 21:54
@jedel1043 jedel1043 removed the waiting-on-review Waiting on reviews from the maintainers label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants