Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move arguments object creation to bytecode #3432

Merged
merged 1 commit into from
Nov 1, 2023

Move `arguments` object creation to opcode

ff6e79b
Select commit
Loading
Failed to load commit list.
Merged

Move arguments object creation to bytecode #3432

Move `arguments` object creation to opcode
ff6e79b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 1, 2023 in 0s

44.83% (-0.04%) compared to 2c12bae

View this Pull Request on Codecov

44.83% (-0.04%) compared to 2c12bae

Details

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (2c12bae) 44.86% compared to head (ff6e79b) 44.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3432      +/-   ##
==========================================
- Coverage   44.86%   44.83%   -0.04%     
==========================================
  Files         487      488       +1     
  Lines       50373    50390      +17     
==========================================
- Hits        22598    22590       -8     
- Misses      27775    27800      +25     
Files Coverage Δ
boa_engine/src/bytecompiler/mod.rs 68.03% <ø> (ø)
boa_engine/src/context/mod.rs 51.17% <100.00%> (-0.17%) ⬇️
boa_engine/src/object/internal_methods/function.rs 89.53% <ø> (-1.56%) ⬇️
boa_engine/src/vm/flowgraph/mod.rs 0.00% <ø> (ø)
boa_engine/src/vm/opcode/arguments.rs 100.00% <100.00%> (ø)
boa_engine/src/vm/opcode/mod.rs 5.00% <ø> (ø)
boa_engine/src/bytecompiler/declarations.rs 52.74% <50.00%> (+0.31%) ⬆️
boa_engine/src/vm/code_block.rs 25.44% <0.00%> (-1.05%) ⬇️
boa_engine/src/vm/opcode/define/mod.rs 42.85% <0.00%> (-14.84%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.