Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor function internal methods #3322

Merged
merged 1 commit into from
Oct 3, 2023

Separate native and JavaScript functions

e72c22a
Select commit
Loading
Failed to load commit list.
Merged

Refactor function internal methods #3322

Separate native and JavaScript functions
e72c22a
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Oct 2, 2023 in 0s

49.46% (+0.01%) compared to 4bdb6c6

View this Pull Request on Codecov

49.46% (+0.01%) compared to 4bdb6c6

Details

Codecov Report

Attention: 83 lines in your changes are missing coverage. Please review.

Comparison is base (4bdb6c6) 49.45% compared to head (e72c22a) 49.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3322      +/-   ##
==========================================
+ Coverage   49.45%   49.46%   +0.01%     
==========================================
  Files         446      446              
  Lines       43948    43896      -52     
==========================================
- Hits        21733    21715      -18     
+ Misses      22215    22181      -34     
Files Coverage Δ
boa_engine/src/builtins/error/type.rs 82.69% <100.00%> (-0.33%) ⬇️
boa_engine/src/builtins/mod.rs 92.49% <100.00%> (-0.07%) ⬇️
boa_engine/src/object/builtins/jsfunction.rs 57.14% <ø> (ø)
...gine/src/object/internal_methods/bound_function.rs 0.00% <ø> (ø)
boa_engine/src/object/internal_methods/proxy.rs 3.35% <ø> (ø)
boa_engine/src/object/jsobject.rs 52.36% <71.42%> (-0.42%) ⬇️
boa_engine/src/object/operations.rs 48.55% <62.50%> (-0.16%) ⬇️
boa_engine/src/object/internal_methods/mod.rs 84.61% <58.33%> (-1.75%) ⬇️
boa_cli/src/debug/function.rs 0.00% <0.00%> (ø)
boa_engine/src/object/mod.rs 31.56% <75.00%> (+0.76%) ⬆️
... and 4 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.