-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor function internal methods #3322
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test262 conformance changes
Fixed tests (70):
|
HalidOdat
force-pushed
the
refactor/function-internal-methods
branch
from
September 30, 2023 13:05
4f96143
to
e97db0c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3322 +/- ##
==========================================
+ Coverage 49.45% 49.46% +0.01%
==========================================
Files 446 446
Lines 43948 43896 -52
==========================================
- Hits 21733 21715 -18
+ Misses 22215 22181 -34
☔ View full report in Codecov by Sentry. |
HalidOdat
commented
Sep 30, 2023
raskad
approved these changes
Sep 30, 2023
HalidOdat
force-pushed
the
refactor/function-internal-methods
branch
from
October 2, 2023 23:34
e97db0c
to
e1ad95b
Compare
HalidOdat
force-pushed
the
refactor/function-internal-methods
branch
from
October 2, 2023 23:39
e1ad95b
to
e72c22a
Compare
jedel1043
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactoring!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the native function from JavaScript function, their internal methods and their storage.
This allows us to remove some unneeded check as well as makes #3295 easier to implement.