Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace #[deny] with #[warn] #3309

Merged
merged 2 commits into from
Sep 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ jobs:
name: Misc
runs-on: ubuntu-latest
timeout-minutes: 60
env:
RUSTFLAGS: -D warnings
steps:
- uses: actions/checkout@v4
- uses: actions-rs/[email protected]
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/webassembly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ jobs:
timeout-minutes: 60
env:
WASM_PACK_PATH: ~/.cargo/bin/wasm-pack
RUSTFLAGS: -D warnings
steps:
- uses: actions/checkout@v4
- uses: actions-rs/[email protected]
Expand Down
7 changes: 5 additions & 2 deletions boa_ast/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@
html_favicon_url = "https://raw.githubusercontent.com/boa-dev/boa/main/assets/logo.svg"
)]
#![cfg_attr(not(test), forbid(clippy::unwrap_used))]
#![warn(missing_docs, clippy::dbg_macro)]
#![deny(
#![warn(
// rustc lint groups https://doc.rust-lang.org/rustc/lints/groups.html
warnings,
future_incompatible,
Expand All @@ -31,6 +30,7 @@
unused,

// rustc allowed-by-default lints https://doc.rust-lang.org/rustc/lints/listing/allowed-by-default.html
missing_docs,
macro_use_extern_crate,
meta_variable_misuse,
missing_abi,
Expand Down Expand Up @@ -59,6 +59,9 @@
rustdoc::invalid_rust_codeblocks,
rustdoc::bare_urls,

// clippy allowed by default
clippy::dbg_macro,

// clippy categories https://doc.rust-lang.org/clippy/
clippy::all,
clippy::correctness,
Expand Down
7 changes: 5 additions & 2 deletions boa_cli/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@
html_favicon_url = "https://raw.githubusercontent.com/boa-dev/boa/main/assets/logo.svg"
)]
#![cfg_attr(not(test), deny(clippy::unwrap_used))]
#![warn(missing_docs, clippy::dbg_macro)]
#![deny(
#![warn(
// rustc lint groups https://doc.rust-lang.org/rustc/lints/groups.html
warnings,
future_incompatible,
Expand All @@ -19,6 +18,7 @@
unused,

// rustc allowed-by-default lints https://doc.rust-lang.org/rustc/lints/listing/allowed-by-default.html
missing_docs,
macro_use_extern_crate,
meta_variable_misuse,
missing_abi,
Expand Down Expand Up @@ -47,6 +47,9 @@
rustdoc::invalid_rust_codeblocks,
rustdoc::bare_urls,

// clippy allowed by default
clippy::dbg_macro,

// clippy categories https://doc.rust-lang.org/clippy/
clippy::all,
clippy::correctness,
Expand Down
7 changes: 5 additions & 2 deletions boa_engine/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,7 @@
html_favicon_url = "https://raw.githubusercontent.com/boa-dev/boa/main/assets/logo.svg"
)]
#![cfg_attr(not(test), forbid(clippy::unwrap_used))]
#![warn(missing_docs, clippy::dbg_macro)]
#![deny(
#![warn(
// rustc lint groups https://doc.rust-lang.org/rustc/lints/groups.html
warnings,
future_incompatible,
Expand All @@ -65,6 +64,7 @@
unused,

// rustc allowed-by-default lints https://doc.rust-lang.org/rustc/lints/listing/allowed-by-default.html
missing_docs,
macro_use_extern_crate,
meta_variable_misuse,
missing_abi,
Expand Down Expand Up @@ -93,6 +93,9 @@
rustdoc::invalid_rust_codeblocks,
rustdoc::bare_urls,

// clippy allowed by default
clippy::dbg_macro,

// clippy categories https://doc.rust-lang.org/clippy/
clippy::all,
clippy::correctness,
Expand Down
9 changes: 6 additions & 3 deletions boa_gc/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@
html_favicon_url = "https://raw.githubusercontent.com/boa-dev/boa/main/assets/logo.svg"
)]
#![cfg_attr(not(test), forbid(clippy::unwrap_used))]
#![warn(missing_docs, clippy::dbg_macro)]
#![deny(
#![warn(
// rustc lint groups https://doc.rust-lang.org/rustc/lints/groups.html
warnings,
future_incompatible,
Expand All @@ -23,6 +22,7 @@
unused,

// rustc allowed-by-default lints https://doc.rust-lang.org/rustc/lints/listing/allowed-by-default.html
missing_docs,
macro_use_extern_crate,
meta_variable_misuse,
missing_abi,
Expand Down Expand Up @@ -51,6 +51,10 @@
rustdoc::invalid_rust_codeblocks,
rustdoc::bare_urls,

// clippy allowed by default
clippy::dbg_macro,
clippy::undocumented_unsafe_blocks,

// clippy categories https://doc.rust-lang.org/clippy/
clippy::all,
clippy::correctness,
Expand All @@ -60,7 +64,6 @@
clippy::perf,
clippy::pedantic,
clippy::nursery,
clippy::undocumented_unsafe_blocks
)]
#![allow(
clippy::module_name_repetitions,
Expand Down
7 changes: 6 additions & 1 deletion boa_icu_provider/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
html_logo_url = "https://raw.githubusercontent.com/boa-dev/boa/main/assets/logo.svg",
html_favicon_url = "https://raw.githubusercontent.com/boa-dev/boa/main/assets/logo.svg"
)]
#![deny(
#![warn(
// rustc lint groups https://doc.rust-lang.org/rustc/lints/groups.html
warnings,
future_incompatible,
Expand All @@ -31,6 +31,7 @@
unused,

// rustc allowed-by-default lints https://doc.rust-lang.org/rustc/lints/listing/allowed-by-default.html
missing_docs,
macro_use_extern_crate,
meta_variable_misuse,
missing_abi,
Expand All @@ -41,6 +42,7 @@
single_use_lifetimes,
trivial_casts,
trivial_numeric_casts,
unreachable_pub,
unsafe_op_in_unsafe_fn,
unused_import_braces,
unused_lifetimes,
Expand All @@ -57,6 +59,9 @@
rustdoc::invalid_rust_codeblocks,
rustdoc::bare_urls,

// clippy allowed by default
clippy::dbg_macro,

// clippy categories https://doc.rust-lang.org/clippy/
clippy::all,
clippy::correctness,
Expand Down
8 changes: 6 additions & 2 deletions boa_interner/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@
html_favicon_url = "https://raw.githubusercontent.com/boa-dev/boa/main/assets/logo.svg"
)]
#![cfg_attr(not(test), forbid(clippy::unwrap_used))]
#![warn(missing_docs, clippy::dbg_macro)]
#![deny(
#![warn(
// rustc lint groups https://doc.rust-lang.org/rustc/lints/groups.html
warnings,
future_incompatible,
Expand All @@ -29,13 +28,15 @@
unused,

// rustc allowed-by-default lints https://doc.rust-lang.org/rustc/lints/listing/allowed-by-default.html
missing_docs,
macro_use_extern_crate,
meta_variable_misuse,
missing_abi,
missing_copy_implementations,
missing_debug_implementations,
non_ascii_idents,
noop_method_call,
single_use_lifetimes,
trivial_casts,
trivial_numeric_casts,
unreachable_pub,
Expand All @@ -56,6 +57,9 @@
rustdoc::invalid_rust_codeblocks,
rustdoc::bare_urls,

// clippy allowed by default
clippy::dbg_macro,

// clippy categories https://doc.rust-lang.org/clippy/
clippy::all,
clippy::correctness,
Expand Down
7 changes: 5 additions & 2 deletions boa_macros/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@
html_favicon_url = "https://raw.githubusercontent.com/boa-dev/boa/main/assets/logo.svg"
)]
#![cfg_attr(not(test), forbid(clippy::unwrap_used))]
#![warn(missing_docs, clippy::dbg_macro)]
#![deny(
#![warn(
// rustc lint groups https://doc.rust-lang.org/rustc/lints/groups.html
warnings,
future_incompatible,
Expand All @@ -19,6 +18,7 @@
unused,

// rustc allowed-by-default lints https://doc.rust-lang.org/rustc/lints/listing/allowed-by-default.html
missing_docs,
macro_use_extern_crate,
meta_variable_misuse,
missing_abi,
Expand Down Expand Up @@ -47,6 +47,9 @@
rustdoc::invalid_rust_codeblocks,
rustdoc::bare_urls,

// clippy allowed by default
clippy::dbg_macro,

// clippy categories https://doc.rust-lang.org/clippy/
clippy::all,
clippy::correctness,
Expand Down
7 changes: 5 additions & 2 deletions boa_parser/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@
html_favicon_url = "https://raw.githubusercontent.com/boa-dev/boa/main/assets/logo.svg"
)]
#![cfg_attr(not(test), forbid(clippy::unwrap_used))]
#![warn(missing_docs, clippy::dbg_macro)]
#![deny(
#![warn(
// rustc lint groups https://doc.rust-lang.org/rustc/lints/groups.html
warnings,
future_incompatible,
Expand All @@ -29,6 +28,7 @@
unused,

// rustc allowed-by-default lints https://doc.rust-lang.org/rustc/lints/listing/allowed-by-default.html
missing_docs,
macro_use_extern_crate,
meta_variable_misuse,
missing_abi,
Expand Down Expand Up @@ -57,6 +57,9 @@
rustdoc::invalid_rust_codeblocks,
rustdoc::bare_urls,

// clippy allowed by default
clippy::dbg_macro,

// clippy categories https://doc.rust-lang.org/clippy/
clippy::all,
clippy::correctness,
Expand Down
7 changes: 5 additions & 2 deletions boa_profiler/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@
html_favicon_url = "https://raw.githubusercontent.com/boa-dev/boa/main/assets/logo.svg"
)]
#![cfg_attr(not(test), forbid(clippy::unwrap_used))]
#![warn(missing_docs, clippy::dbg_macro)]
#![deny(
#![warn(
// rustc lint groups https://doc.rust-lang.org/rustc/lints/groups.html
warnings,
future_incompatible,
Expand All @@ -26,6 +25,7 @@
unused,

// rustc allowed-by-default lints https://doc.rust-lang.org/rustc/lints/listing/allowed-by-default.html
missing_docs,
macro_use_extern_crate,
meta_variable_misuse,
missing_abi,
Expand Down Expand Up @@ -54,6 +54,9 @@
rustdoc::invalid_rust_codeblocks,
rustdoc::bare_urls,

// clippy allowed by default
clippy::dbg_macro,

// clippy categories https://doc.rust-lang.org/clippy/
clippy::all,
clippy::correctness,
Expand Down
8 changes: 5 additions & 3 deletions boa_runtime/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@
html_favicon_url = "https://raw.githubusercontent.com/boa-dev/boa/main/assets/logo.svg"
)]
#![cfg_attr(not(test), forbid(clippy::unwrap_used))]
#![warn(missing_docs, clippy::dbg_macro)]
#![deny(
#![warn(
// rustc lint groups https://doc.rust-lang.org/rustc/lints/groups.html
warnings,
future_incompatible,
Expand All @@ -59,6 +58,7 @@
unused,

// rustc allowed-by-default lints https://doc.rust-lang.org/rustc/lints/listing/allowed-by-default.html
missing_docs,
macro_use_extern_crate,
meta_variable_misuse,
missing_abi,
Expand Down Expand Up @@ -87,6 +87,9 @@
rustdoc::invalid_rust_codeblocks,
rustdoc::bare_urls,

// clippy allowed by default
clippy::dbg_macro,

// clippy categories https://doc.rust-lang.org/clippy/
clippy::all,
clippy::correctness,
Expand All @@ -96,7 +99,6 @@
clippy::perf,
clippy::pedantic,
clippy::nursery,
clippy::undocumented_unsafe_blocks
)]
#![allow(
clippy::module_name_repetitions,
Expand Down
7 changes: 5 additions & 2 deletions boa_tester/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
html_favicon_url = "https://raw.githubusercontent.com/boa-dev/boa/main/assets/logo.svg"
)]
#![cfg_attr(not(test), deny(clippy::unwrap_used))]
#![warn(missing_docs, clippy::dbg_macro)]
#![deny(
#![warn(
// rustc lint groups https://doc.rust-lang.org/rustc/lints/groups.html
warnings,
future_incompatible,
Expand All @@ -22,6 +21,7 @@
unused,

// rustc allowed-by-default lints https://doc.rust-lang.org/rustc/lints/listing/allowed-by-default.html
missing_docs,
macro_use_extern_crate,
meta_variable_misuse,
missing_abi,
Expand Down Expand Up @@ -50,6 +50,9 @@
rustdoc::invalid_rust_codeblocks,
rustdoc::bare_urls,

// clippy allowed by default
clippy::dbg_macro,

// clippy categories https://doc.rust-lang.org/clippy/
clippy::all,
clippy::correctness,
Expand Down
7 changes: 5 additions & 2 deletions boa_wasm/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@
html_favicon_url = "https://raw.githubusercontent.com/boa-dev/boa/main/assets/logo.svg"
)]
#![cfg_attr(not(test), forbid(clippy::unwrap_used))]
#![warn(missing_docs, clippy::dbg_macro)]
#![deny(
#![warn(
// rustc lint groups https://doc.rust-lang.org/rustc/lints/groups.html
warnings,
future_incompatible,
Expand All @@ -19,6 +18,7 @@
unused,

// rustc allowed-by-default lints https://doc.rust-lang.org/rustc/lints/listing/allowed-by-default.html
missing_docs,
macro_use_extern_crate,
meta_variable_misuse,
missing_abi,
Expand Down Expand Up @@ -47,6 +47,9 @@
rustdoc::invalid_rust_codeblocks,
rustdoc::bare_urls,

// clippy allowed by default
clippy::dbg_macro,

// clippy categories https://doc.rust-lang.org/clippy/
clippy::all,
clippy::correctness,
Expand Down
Loading