Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace #[deny] with #[warn] #3309

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Replace #[deny] with #[warn] #3309

merged 2 commits into from
Sep 26, 2023

Conversation

jedel1043
Copy link
Member

See https://rust-unofficial.github.io/patterns/anti_patterns/deny-warnings.html for context.

This also improves a bit the prototyping experience, since now we can compile and run with warnings even if there are missing docs or suboptimal code patterns.

@jedel1043 jedel1043 added enhancement New feature or request github_actions Pull requests that update Github_actions code labels Sep 25, 2023
@jedel1043 jedel1043 added this to the v0.18.0 milestone Sep 25, 2023
@jedel1043 jedel1043 requested a review from a team September 25, 2023 22:58
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,574 95,574 0
Passed 75,165 75,165 0
Ignored 19,494 19,494 0
Failed 915 915 0
Panics 0 0 0
Conformance 78.65% 78.65% 0.00%

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a7ffa00) 49.79% compared to head (51487ad) 49.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3309      +/-   ##
==========================================
- Coverage   49.79%   49.79%   -0.01%     
==========================================
  Files         441      441              
  Lines       43081    43081              
==========================================
- Hits        21452    21451       -1     
- Misses      21629    21630       +1     
Files Coverage Δ
boa_ast/src/lib.rs 75.00% <ø> (ø)
boa_cli/src/main.rs 0.61% <ø> (ø)
boa_engine/src/lib.rs 73.33% <ø> (ø)
boa_gc/src/lib.rs 99.45% <ø> (ø)
boa_icu_provider/src/lib.rs 100.00% <ø> (ø)
boa_interner/src/lib.rs 87.37% <ø> (ø)
boa_macros/src/lib.rs 0.00% <ø> (ø)
boa_profiler/src/lib.rs 66.66% <ø> (ø)
boa_tester/src/main.rs 0.00% <ø> (ø)
boa_wasm/src/lib.rs 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nekevss nekevss requested a review from a team September 25, 2023 23:21
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! :)

@jedel1043 jedel1043 added this pull request to the merge queue Sep 26, 2023
Merged via the queue into main with commit 0bb51b1 Sep 26, 2023
10 checks passed
jedel1043 added a commit that referenced this pull request Sep 26, 2023
* Change deny lints to warn lints

* Deny warnings on CI
@jedel1043 jedel1043 deleted the deny-to-warn branch September 26, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants