-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace #[deny] with #[warn] #3309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
enhancement
New feature or request
github_actions
Pull requests that update Github_actions code
labels
Sep 25, 2023
Test262 conformance changes
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3309 +/- ##
==========================================
- Coverage 49.79% 49.79% -0.01%
==========================================
Files 441 441
Lines 43081 43081
==========================================
- Hits 21452 21451 -1
- Misses 21629 21630 +1
☔ View full report in Codecov by Sentry. |
nekevss
approved these changes
Sep 25, 2023
HalidOdat
reviewed
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change! :)
HalidOdat
approved these changes
Sep 25, 2023
jedel1043
added a commit
that referenced
this pull request
Sep 26, 2023
* Change deny lints to warn lints * Deny warnings on CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://rust-unofficial.github.io/patterns/anti_patterns/deny-warnings.html for context.
This also improves a bit the prototyping experience, since now we can compile and run with warnings even if there are missing docs or suboptimal code patterns.