providers/supermicro/supermicro.go: Initialize sum 'client' during serviceclient init #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splaspood
force-pushed
the
bios-cfg-regression-fix-0
branch
from
46fac38 to
43237b1
Compare
jakeschuurmans
previously approved these changes
Oct 28, 2024
joelrebel
reviewed
Oct 28, 2024
jakeschuurmans
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
A regression crept in recently where the 'sum' client was not being assigned to the 'serviceclient' when the supermicro provider was instantiated. This change fixes that problem.