Nil pointer safety #408
Merged
Nil pointer safety #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignoring an error and returning nil objects causes `panic: runtime error: invalid memory address or nil pointer dereference` issues. Signed-off-by: Jacob Weinstock <[email protected]>
A recent bug showed that a nil is still a type so type asserting a nil will still work. We add a nil check so that methods on interfaces don't get called when the interface/implementation is nil. Signed-off-by: Jacob Weinstock <[email protected]>
joelrebel
reviewed
Dec 14, 2024
| sc := &serviceClient{host: host, port: port, user: user, pass: pass, client: client} | ||
|
|
||
| if !strings.HasPrefix(host, "https://") && !strings.HasPrefix(host, "http://") { | ||
| sc.host = "https://" + host | ||
| } | ||
|
|
||
| // sum is only for firmware related operations. Failing the client entirely because of a sum error |
There was a problem hiding this comment.
The sum code can be removed entirely since bmclib was 'hard' forked (for the environment where sum was required to run remotely). I'll get round to cleaning this up sometime soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
Fix bug introduced by #402. This PR handles errors properly and adds some nil checking in the
bmcpackage. By ignoring an error and returning nil objects it causespanic: runtime error: invalid memory address or nil pointer dereferencefor clients.Checklist
The HW vendor this change applies to (if applicable)
The HW model number, product name this change applies to (if applicable)
The BMC firmware and/or BIOS versions that this change applies to (if applicable)
What version of tooling - vendor specific or opensource does this change depend on (if applicable)
Description for changelog/release notes