-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++20-ify #267
Open
voidanix
wants to merge
19
commits into
blue-nebula:master
Choose a base branch
from
voidanix:cxx20
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
C++20-ify #267
Commits on May 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4040038 - Browse repository at this point
Copy the full SHA 4040038View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7272660 - Browse repository at this point
Copy the full SHA 7272660View commit details -
Convert weapon selection system to std::vector
Also introduces a new "inrange" function, useful for future refactorings to std::vector
Configuration menu - View commit details
-
Copy full SHA for 2ba65bb - Browse repository at this point
Copy the full SHA 2ba65bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for f07eb85 - Browse repository at this point
Copy the full SHA f07eb85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b800a4 - Browse repository at this point
Copy the full SHA 3b800a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8143e6 - Browse repository at this point
Copy the full SHA c8143e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb50c90 - Browse repository at this point
Copy the full SHA bb50c90View commit details -
Configuration menu - View commit details
-
Copy full SHA for af57554 - Browse repository at this point
Copy the full SHA af57554View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd33dfb - Browse repository at this point
Copy the full SHA dd33dfbView commit details -
Configuration menu - View commit details
-
Copy full SHA for d7b723e - Browse repository at this point
Copy the full SHA d7b723eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3eb9dac - Browse repository at this point
Copy the full SHA 3eb9dacView commit details -
The mattrig macro expands the mw argument at one point into: if (curmat != MAT_WATER ? S_SPLASH2 : S_SPLASH1 >= 0) Co-authored-by: Robert Alm Nilsson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 64ae458 - Browse repository at this point
Copy the full SHA 64ae458View commit details -
There should be no reason to overwrite this as the C++ spec already specifies it. Compilers nowadays also gift us a dedicated warning for this kind of situation (-Wzero-as-null-pointer-constant). Remove it and specify <cstddef> to still make NULL accessible.
Configuration menu - View commit details
-
Copy full SHA for d938486 - Browse repository at this point
Copy the full SHA d938486View commit details -
engine: Use std::atomic, not volatile for errors
This usage of volatile has been deprecated since C++20: use std::atomic in its place.
Configuration menu - View commit details
-
Copy full SHA for 7cdfbc2 - Browse repository at this point
Copy the full SHA 7cdfbc2View commit details -
weapons: Prevent arithmetic between different enum types
Deprecated in C++20
Configuration menu - View commit details
-
Copy full SHA for 5b28d72 - Browse repository at this point
Copy the full SHA 5b28d72View commit details
Commits on May 11, 2023
-
Enable new language features that allow everyone to write better, safer and faster C++ code (and not let the game die).
Configuration menu - View commit details
-
Copy full SHA for 5e849f7 - Browse repository at this point
Copy the full SHA 5e849f7View commit details -
As of C++17, we can specify whether we want our switch cases to fall-through or not (in presence of a break statement): specifying these avoids unnecessary compiler warnings and makes the code clearer as to what it is doing. Specify the fallthrough attribute where needed and replace the comments that specify its explicit usage.
Configuration menu - View commit details
-
Copy full SHA for c4fe739 - Browse repository at this point
Copy the full SHA c4fe739View commit details -
As of C++17, the STL already provides us with std::clamp which in turn makes the implementation here provided redundant and possibly broken: remove the implementation here defined and use the one provided by <algorithm>.
Configuration menu - View commit details
-
Copy full SHA for ef24b40 - Browse repository at this point
Copy the full SHA ef24b40View commit details -
tools: Use STL defined mathematical constants
As of C++20, the STL already provides us with mathematical constants that make the macro-fied ones used in tools redundant and possibly inaccurate: remove our definitions of the macros and use the constants defined in the <numbers> header.
Configuration menu - View commit details
-
Copy full SHA for bbcb572 - Browse repository at this point
Copy the full SHA bbcb572View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.