-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [ISSUE-119] feat: adding a receiver as parameter in the accept swap function #149
feat: [ISSUE-119] feat: adding a receiver as parameter in the accept swap function #149
Conversation
I'm fixing the conflicts |
b6dae89
to
3bc87fd
Compare
Fixed all conflicts in the PR with main branch and errors in the unit tests :) |
Okay, now it's ready to review rs |
…te approveToken script
9734d5d
to
3d17eec
Compare
Fixed the PR conflicts :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting for changings in the following files:
scripts/approveToken.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script is not part of the proposal and should not be committed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This addition is not part of the issue and should be added in this PR
@0xjoaovpsantos Happy New Year, how is this task going? We just need minor changes to approve this! |
HEEEEEEEY @0xneves HAPPY NEW YEAR MANNN Sorry for the delay, I fixed this detail :) |
This PR close #119
Proposal in the issue:
Plus:
Tests:
Example transaction: https://sepolia.etherscan.io/tx/0xf9b626c70167d25319884791913857ce748eee1696cb8c35d932ae9ef267f193