Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [ISSUE-119] feat: adding a receiver as parameter in the accept swap function #149

Conversation

0xjoaovpsantos
Copy link
Contributor

@0xjoaovpsantos 0xjoaovpsantos commented Dec 19, 2023

This PR close #119

Proposal in the issue:

  • add an address type into the acceptSwap parameter with the name of receiver.
  • instead of sending the assets to the msg.sender, send it to the receiver instead.

Plus:

  • I created a "approveToken.ts" script to help us to approve tokens to test the flow creating and accepting swaps, it's only a suggestion, I can remove it if you think it's not necessary :)

Tests:

Example transaction: https://sepolia.etherscan.io/tx/0xf9b626c70167d25319884791913857ce748eee1696cb8c35d932ae9ef267f193

  • msg.sender send to owner of swap created
  • owner of swap created send to receiver

@0xjoaovpsantos
Copy link
Contributor Author

I'm fixing the conflicts

@0xjoaovpsantos 0xjoaovpsantos force-pushed the issue-119-adding-receiver-parameter-accept-swap-function branch from b6dae89 to 3bc87fd Compare December 19, 2023 19:32
@0xjoaovpsantos
Copy link
Contributor Author

Fixed all conflicts in the PR with main branch and errors in the unit tests :)

@0xjoaovpsantos
Copy link
Contributor Author

Okay, now it's ready to review rs

@0xjoaovpsantos
Copy link
Contributor Author

@0xneves

@0xjoaovpsantos 0xjoaovpsantos force-pushed the issue-119-adding-receiver-parameter-accept-swap-function branch from 9734d5d to 3d17eec Compare December 21, 2023 17:12
@0xjoaovpsantos
Copy link
Contributor Author

Fixed the PR conflicts :)

Copy link
Contributor

@0xneves 0xneves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting for changings in the following files:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script is not part of the proposal and should not be committed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition is not part of the issue and should be added in this PR

@0xneves
Copy link
Contributor

0xneves commented Jan 3, 2024

@0xjoaovpsantos Happy New Year, how is this task going? We just need minor changes to approve this!

@0xjoaovpsantos
Copy link
Contributor Author

HEEEEEEEY @0xneves HAPPY NEW YEAR MANNN

Sorry for the delay, I fixed this detail :)

@0xneves 0xneves merged commit af3370f into blockful-io:main Jan 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: adding a receiver as parameter in the accept swap function
2 participants