Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding a receiver as parameter in the accept swap function #119

Closed
0xneves opened this issue Dec 4, 2023 · 4 comments · Fixed by #149
Closed

feat: adding a receiver as parameter in the accept swap function #119

0xneves opened this issue Dec 4, 2023 · 4 comments · Fixed by #149
Assignees
@0xjoaovpsantos
Labels
enhancement New feature or request
Milestone
Swaplace v1.0.0

Comments

@0xneves
Copy link
Contributor

0xneves commented Dec 4, 2023 •
edited
Loading

There is no reason why not allowing to choose the receiver when calling acceptSwap, which is currently setting msg.sender as the receiver of the assets.

Proposal:

  • add an address type into the acceptSwap parameter with the name of receiver.
  • instead of sending the assets to the msg.sender, send it to the receiver instead.
@0xneves 0xneves added this to Swaplace Dec 4, 2023
@0xneves 0xneves converted this from a draft issue Dec 4, 2023
@0xneves 0xneves added the enhancement New feature or request label Dec 4, 2023
@0xneves 0xneves added this to the Swaplace v1.0.0 milestone Dec 4, 2023
@0xneves 0xneves moved this from 💡 Ideas to 🔖 TODO in Swaplace Dec 4, 2023
@blackbeard002
Copy link
Contributor

Hey @0xneves I wanna work on this

@0xneves
Copy link
Contributor Author

0xneves commented Dec 14, 2023

Hey @blackbeard002

I was waiting your PR 🙈

@0xneves
Copy link
Contributor Author

0xneves commented Dec 19, 2023 •
edited
Loading

This task is not hard, come on guys

@0xjoaovpsantos 0xjoaovpsantos mentioned this issue Dec 19, 2023
Merged
2 tasks
@0xjoaovpsantos
Copy link
Contributor

@0xneves @blackbeard002

HEY HEY GUYS

I saw that this issue is stopped a while and I did it guys :)

PR with all documentation about: #149

@0xneves 0xneves moved this from 🔖 TODO to 🕵️‍♀️ In Review in Swaplace Dec 19, 2023
0xjoaovpsantos added a commit to 0xjoaovpsantos/swaplace-contracts that referenced this issue Jan 3, 2024
@0xjoaovpsantos
fix: remove the scripts that not part of the proposal blockful-io#119
70d32bf
@0xneves 0xneves added the good first issue Good for newcomers label Jan 15, 2024
@0xneves 0xneves moved this from 🕵️‍♀️ In Review to ✅ Done in Swaplace Jan 16, 2024
@0xneves 0xneves removed the good first issue Good for newcomers label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xjoaovpsantos 0xjoaovpsantos

Labels
enhancement New feature or request
Projects
Swaplace
Status: ✅ Done
Milestone
Swaplace v1.0.0
3 participants
@blackbeard002 @0xjoaovpsantos @0xneves