-
-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Cortex handling unification #1664
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s that's all common too
… probe routine for Cortex-A and -R parts
…old support out of the build
…nts work properly on VMSA targets
…HIBIT_NRST and put it in the unified Cortex header
…cked prior to halt in cortexar_probe()
…riable in cortexm_probe() + the `PROBE()` macro
esden
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
This PR we unify the Cortex-A and Cortex-R support and perform some related cleanup to the Cortex-M support.
This results in a stable extensible basis for supporting Cortex-A/R parts using part-specific probe routines just like in the Cortex-M support, which solves several major headaches in supporting new parts in the Cortex-A side of things.
There will be two follow-up PRs that add proper support for the STM32MP15's Cortex-A cores, and the Zynq-7000 series. There are still some devtype issues in the ADIv5 component LUT but these should now be easily solved.
NB: This does not provide support for 64-bit Cortex devices, support for such devices needs some rework of the ADIv5 implementation and the implementation of 32- and 64-bit target address types w/ a union for holding an either address value. This is known about and in the pipeline but not handled here.
Your checklist for this pull request
make PROBE_HOST=native
)make PROBE_HOST=hosted
)Closing issues