Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Cortex handling unification #1664

Merged
merged 22 commits into from
Oct 31, 2023
Merged

Conversation

dragonmux
Copy link
Member

Detailed description

This PR we unify the Cortex-A and Cortex-R support and perform some related cleanup to the Cortex-M support.

This results in a stable extensible basis for supporting Cortex-A/R parts using part-specific probe routines just like in the Cortex-M support, which solves several major headaches in supporting new parts in the Cortex-A side of things.

There will be two follow-up PRs that add proper support for the STM32MP15's Cortex-A cores, and the Zynq-7000 series. There are still some devtype issues in the ADIv5 component LUT but these should now be easily solved.

NB: This does not provide support for 64-bit Cortex devices, support for such devices needs some rework of the ADIv5 implementation and the implementation of 32- and 64-bit target address types w/ a union for holding an either address value. This is known about and in the pipeline but not handled here.

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

Closing issues

…HIBIT_NRST and put it in the unified Cortex header
…riable in cortexm_probe() + the `PROBE()` macro
@dragonmux dragonmux added the Enhancement General project improvement label Oct 31, 2023
@dragonmux dragonmux added this to the v2.0 release milestone Oct 31, 2023
Copy link
Member

@esden esden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esden esden merged commit 0a47c1f into main Oct 31, 2023
6 checks passed
@dragonmux dragonmux deleted the feature/cortex-handling-unification branch October 31, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement General project improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants