Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: gdb_main.c cleanup #1658

Merged
merged 2 commits into from
Oct 29, 2023
Merged

Feature: gdb_main.c cleanup #1658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6169c5
gdb_main: Fixed a clang-tidy lint about a pointless assignment left o…
dragonmux Oct 9, 2023
31ff9ca
target: Added some documentation on how the `TARGET_HALT_{BREAK,WATCH…
dragonmux Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/gdb_main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,6 @@ int gdb_main_loop(target_controller_s *tc, char *pbuf, size_t pbuf_size, size_t

target_halt_resume(cur_target, single_step);
SET_RUN_STATE(true);
single_step = false;
/* fall through */
case '?': { /* '?': Request reason for target halt */
/*
Expand Down Expand Up @@ -438,7 +437,7 @@ static void exec_q_supported(const char *packet, const size_t length)
(void)packet;
(void)length;

/*
/*
* This is the first packet sent by GDB, so we can reset the NoAckMode flag here in case
* the previous session was terminated abruptly with NoAckMode enabled
*/
Expand Down Expand Up @@ -527,9 +526,9 @@ static void exec_q_thread_info(const char *packet, const size_t length)
gdb_putpacketz("l");
}

/*
/*
* GDB will send the packet 'QStartNoAckMode' to enable NoAckMode
*
*
* To tell GDB to not use NoAckMode do the following before connnecting to the probe:
* set remote noack-packet off
*/
Expand Down
5 changes: 5 additions & 0 deletions src/include/target.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,12 @@ typedef enum target_halt_reason {
TARGET_HALT_ERROR, /* Failed to read target status */
TARGET_HALT_REQUEST,
TARGET_HALT_STEPPING,
/*
* Used to both indicate that the target hit a breakpoint, and to
* indicate that the target hit a watchpoint but we can't figure out which
*/
TARGET_HALT_BREAKPOINT,
/* Used to indicate the target hit a watchpoint and we know which */
TARGET_HALT_WATCHPOINT,
TARGET_HALT_FAULT,
} target_halt_reason_e;
Expand Down