Feature: gdb_main.c cleanup #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver from the gdb_main_loop() restructure
…}POINT` values are used
dragonmux
added
Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
This PR fixes a clang-tidy lint in
gdb_main_loop()and adds some documentation to the target_halt_reason enumeration. It does not materially change the firmware (the assignment removed is provably unused) and this PR serves as a predicate to #1657 which presently contains a merge commit for the branch.Your checklist for this pull request
make PROBE_HOST=native)make PROBE_HOST=hosted)Closing issues