Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quat::from_rotation_arc #129

Merged
merged 16 commits into from
Feb 11, 2021
Merged

Quat::from_rotation_arc #129

merged 16 commits into from
Feb 11, 2021

Conversation

emilk
Copy link
Contributor

@emilk emilk commented Feb 10, 2021

Here are some very useful functions! In particular Quat::from_rotation_arc for when you want the quaternion that rotates one vector to another.

@emilk emilk mentioned this pull request Feb 10, 2021
Open
26 tasks
emilk
emilk commented Feb 10, 2021
View reviewed changes
src/quat.rs Outdated Show resolved Hide resolved
emilk
emilk commented Feb 10, 2021
View reviewed changes
tests/vec3.rs Outdated Show resolved Hide resolved
bitshifter
bitshifter reviewed Feb 11, 2021
View reviewed changes
src/quat.rs Outdated Show resolved Hide resolved
src/vec3.rs Outdated Show resolved Hide resolved
@emilk
Copy link
Contributor Author

emilk commented Feb 11, 2021

This became a little bit more work and a bigger PR than I had anticipated, but I think it is done now :)

emilk added 16 commits February 11, 2021 15:06
@emilk
Add Vec3::any_orthogonal and Vec3::any_orthonormal
4014786
@emilk
Add Quat::from_rotation_arc
4185443
@emilk
Use std::$t::consts::PI instead of hard-coded tau
d0dfadd
@emilk
Extend test vectors for any_orthogonal
a7b8846
@emilk
Document that Quat::from_axis_angle requires a normalized axis
ffa0554
@emilk
Quat::from_rotation_arc requires input vectors to be normalized
0a04680 
Also improved the test coverage
@emilk
Add Vec3::any_orthonormal_pair and optimize any_orthonormal
a2d6a7a 
and add benchmarks for the any_ortho* family of functions
@emilk
Use more eplicit names
9031e25
@emilk
Add pathological cases to from_rotation_arc test, and note the bad …
5d4c7ec 
…accuracy
@emilk
use core::f32 instead of std::f32
1b5fd3d
@emilk
Improve accuracy of from_rotation_arc
eea0db6
@emilk
Use core epsilon
382f2f2
@emilk
More pathological test cases
5990730
@emilk
Test from_rotation_arc_colinear
89cbea7
@emilk
Unify test vectors with a macro
fba71c4
@emilk
Use EPSILON from core
1e5abb9
@bitshifter bitshifter merged commit a0308aa into bitshifter:master Feb 11, 2021
@hrydgard hrydgard deleted the rotation-arc branch February 18, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitshifter bitshifter bitshifter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @bitshifter